Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] Invoke ErrorHandler on preparing connection string when reconnecting #1397

Merged
merged 1 commit into from Sep 12, 2023
Merged

[ADDED] Invoke ErrorHandler on preparing connection string when reconnecting #1397

merged 1 commit into from Sep 12, 2023

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Sep 11, 2023 •
edited

Resolves #1388

@piotrpio
[ADDED] Invoke ErrorHandler on preparing connection string when recon…
ee94577 
…necting

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
wallyqs
wallyqs approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 6740b12 into main Sep 12, 2023
2 checks passed
@piotrpio piotrpio deleted the error-on-connect-proto branch September 12, 2023 06:20
@piotrpio piotrpio mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nc.processConnectInit() does not call errorHandler, if it fails
2 participants
@piotrpio @wallyqs