[FIXED] Recreating ordered consumers on server restart #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
reset-ordered-consumer
branch
from
eb6a4ac
to
79f1255
Compare
Jarema
reviewed
Oct 14, 2023
| if c.currentConsumer.subscriptions[""] != nil { | ||
| c.currentConsumer.subscriptions[""].Stop() | ||
| } | ||
| consName := c.currentConsumer.CachedInfo().Name |
There was a problem hiding this comment.
are we confident that consumer name is updated after recreation, so we always delete the proper one?
There was a problem hiding this comment.
Should be good, in line 443 we do:
c.currentConsumer = cons.(*pullConsumer)This is done right after successful create.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
reset-ordered-consumer
branch
from
fbe2afa
to
3ef9c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.