Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Eliminate race condition in pull subscription stop #1454

Merged
merged 1 commit into from Dec 1, 2023
Merged

[FIXED] Eliminate race condition in pull subscription stop #1454

merged 1 commit into from Dec 1, 2023

Conversation

evanofslack
Copy link
Contributor

Addresses issue #1453

Switch from two separate atomic calls of Load and Store to a single CompareAndSwap to eliminate race condition when calling consContext.Stop()

piotrpio
piotrpio approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@piotrpio piotrpio merged commit 4af26aa into nats-io:main Dec 1, 2023
1 check failed
@evanofslack evanofslack deleted the consumer-ctx-race branch December 5, 2023 15:56
@piotrpio piotrpio mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

@lrobwebster lrobwebster lrobwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanofslack @piotrpio @lrobwebster