[IMPROVED] Fix flaky tests #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
fix-build-tests
branch
from
ccc39ed
to
f54e634
Compare
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
fix-build-tests
branch
from
f54e634
to
c3e230f
Compare
piotrpio
changed the title
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Jarema
requested changes
Feb 26, 2024
| // we know this request will take longer so extend the timeout | ||
| expirationTimer.Reset(100 * time.Millisecond) | ||
|
|
||
| // slower reply which would have hit original timeout | ||
| time.Sleep(90 * time.Millisecond) | ||
| time.Sleep(70 * time.Millisecond) |
There was a problem hiding this comment.
What's the reason for this change here?
There was a problem hiding this comment.
This test depends on request either timing out or not depending on the circumstances. The expiration timer is reset in each subscribe callback to 100ms - sleeping for 90ms was making it fail quite often if there the subsequent request had 10ms delay. Now it's 30ms "buffer", which makes it less, but still, flaky...
I get why this test is useful but its tough to fix it entirely while retaining the logic.
There was a problem hiding this comment.
Oh, gotcha. That feels pretty flaky no matter what we set here, seeing faster or slower machines running it...
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com