Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[micro] Add API to read Reply subject from micro.Request #1589

Merged
merged 1 commit into from Apr 9, 2024

Conversation

mcosta74
Copy link
Contributor

Allow to check if the request contains a Reply subject

Fixes #1579

Signed-off-by: Massimo Costa costa.massimo@gmail.com

Fixes nats-io#1579

Signed-off-by: Massimo Costa <costa.massimo@gmail.com>
@themartorana
Copy link

themartorana commented Apr 4, 2024

Came here to submit this same PR, thanks @mcosta74 for beating me to it. Definitely need this exposed to be able to move from our own proprietary subject router that passes the nats.Msg around to NATS micro. .Reply is the only concrete nats.Msg property that hasn't been exposed by the micro.Request interface.

For our purpose, sometimes we hand messages around multiple microservices before responding to a client, and need to be able to pass the reply subject to the down-line handlers. Easy to do with nats.Msg, but not micro.

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 1eafa27 into nats-io:main Apr 9, 2024
1 check passed
@mcosta74 mcosta74 deleted the feat/micro-reply branch April 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[micro] Add API to read Reply subject from micro.Request
3 participants