Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] KV discard policy in jetstream pkg #1616

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[FIXED] KV discard policy in jetstream pkg #1616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions jetstream/kv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,7 @@ func (js *jetStream) prepareKeyValueConfig(ctx context.Context, cfg KeyValueConf
AllowDirect: true,
RePublish: cfg.RePublish,
Compression: compression,
Discard: DiscardNew,
}
if cfg.Mirror != nil {
// Copy in case we need to make changes so we do not change caller's version.
Expand Down
37 changes: 36 additions & 1 deletion jetstream/test/kv_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,11 +1481,46 @@ func TestKeyValueCreate(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()

kv, err := js.CreateKeyValue(ctx, jetstream.KeyValueConfig{Bucket: "TEST"})
kv, err := js.CreateKeyValue(ctx, jetstream.KeyValueConfig{
Bucket: "TEST",
Description: "Test KV",
MaxValueSize: 128,
History: 10,
TTL: 1 * time.Hour,
MaxBytes: 1024,
Storage: jetstream.FileStorage,
})
if err != nil {
t.Fatalf("Error creating kv: %v", err)
}

expectedStreamConfig := jetstream.StreamConfig{
Name: "KV_TEST",
Description: "Test KV",
Subjects: []string{"$KV.TEST.>"},
MaxMsgs: -1,
MaxBytes: 1024,
Discard: jetstream.DiscardNew,
MaxAge: 1 * time.Hour,
MaxMsgsPerSubject: 10,
MaxMsgSize: 128,
Storage: jetstream.FileStorage,
DenyDelete: true,
AllowRollup: true,
AllowDirect: true,
MaxConsumers: -1,
Replicas: 1,
Duplicates: 2 * time.Minute,
}

stream, err := js.Stream(ctx, "KV_TEST")
if err != nil {
t.Fatalf("Error getting stream: %v", err)
}
if !reflect.DeepEqual(stream.CachedInfo().Config, expectedStreamConfig) {
t.Fatalf("Expected stream config to be %+v, got %+v", expectedStreamConfig, stream.CachedInfo().Config)
}

_, err = kv.Create(ctx, "key", []byte("1"))
if err != nil {
t.Fatalf("Error creating key: %v", err)
Expand Down
37 changes: 36 additions & 1 deletion test/kv_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,11 +1376,46 @@ func TestKeyValueCreate(t *testing.T) {
nc, js := jsClient(t, s)
defer nc.Close()

kv, err := js.CreateKeyValue(&nats.KeyValueConfig{Bucket: "TEST"})
kv, err := js.CreateKeyValue(&nats.KeyValueConfig{
Bucket: "TEST",
Description: "Test KV",
MaxValueSize: 128,
History: 10,
TTL: 1 * time.Hour,
MaxBytes: 1024,
Storage: nats.FileStorage,
})
if err != nil {
t.Fatalf("Error creating kv: %v", err)
}

expectedStreamConfig := nats.StreamConfig{
Name: "KV_TEST",
Description: "Test KV",
Subjects: []string{"$KV.TEST.>"},
MaxMsgs: -1,
MaxBytes: 1024,
Discard: nats.DiscardNew,
MaxAge: 1 * time.Hour,
MaxMsgsPerSubject: 10,
MaxMsgSize: 128,
Storage: nats.FileStorage,
DenyDelete: true,
AllowRollup: true,
AllowDirect: true,
MaxConsumers: -1,
Replicas: 1,
Duplicates: 2 * time.Minute,
}

si, err := js.StreamInfo("KV_TEST")
if err != nil {
t.Fatalf("Error getting stream info: %v", err)
}
if !reflect.DeepEqual(si.Config, expectedStreamConfig) {
t.Fatalf("Expected stream config to be %+v, got %+v", expectedStreamConfig, si.Config)
}

_, err = kv.Create("key", []byte("1"))
if err != nil {
t.Fatalf("Error creating key: %v", err)
Expand Down