Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not hang closed callbacks when Drain() called in reconnecting state #531

Merged
merged 1 commit into from Nov 18, 2019
Merged

Do not hang closed callbacks when Drain() called in reconnecting state #531

merged 1 commit into from Nov 18, 2019

Conversation

derekcollison
Copy link
Member

Noticed this on nats-echo example.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Do not hang closed callbacks when Drain() called in reconnecting state
e6d41f2 
Signed-off-by: Derek Collison <derek@nats.io>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.627% when pulling e6d41f2 on drain_hang into 8782052 on master.

kozlovic
kozlovic approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 5a67486 into master Nov 18, 2019
@derekcollison derekcollison deleted the drain_hang branch November 18, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derekcollison @coveralls @kozlovic