parser: rm unused OP_CONNECT & CONNECT_ARG. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure about removing this. It is still on the server side, and while it is only referenced in the parser on the server side, it is essentially part of the protocol. |
|
@krobertson ok, let me know as we can add the rest of the states as there is no where to go from nc.ps.state = OP_C . And add a test case. |
|
I did notice that the node client using a different model does use CONNECT, https://github.com/derekcollison/node-nats/blob/master/lib/nats.js#L338 . |
derekcollison
added a commit
that referenced
this pull request
Jan 20, 2016
parser: rm unused OP_CONNECT & CONNECT_ARG.
TheGhoul21
pushed a commit
to TheGhoul21/nats.go
that referenced
this pull request
Jun 20, 2024
Cut version 0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the test coverage and this caught my eye.