Release v1.10.0 #569
Merged
Release v1.10.0 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
approved these changes
May 14, 2020
README.md
Outdated
| @@ -325,6 +325,17 @@ nc, err := nats.Connect(servers) | |||
| // This example means 10 seconds total per backend. | |||
| nc, err = nats.Connect(servers, nats.MaxReconnects(5), nats.ReconnectWait(2 * time.Second)) | |||
|
|
|||
| // You can also add some jitter for the reconnection. | |||
| // This call will add up to 100 milliseconds for non TLS connections and 1 second for TLS connections. | |||
| nc, err = nats.Connect(servers, nats.ReconnectJitter(100 * time.Millisecond, time.Second)) | |||
There was a problem hiding this comment.
That is the default though now yes? Maybe show different values and call out the defaults here that you get with nothing added.
There was a problem hiding this comment.
You are right. I did change to:
// You can also add some jitter for the reconnection.
// This call will add up to 500 milliseconds for non TLS connections and 2 seconds for TLS connections.
// If not specified, the library defaults to 100 milliseconds and 1 second, respectively.
nc, err = nats.Connect(servers, nats.ReconnectJitter(500*time.Millisecond, 2*time.Second))
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Kozlovic ivan@synadia.com