Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Msg variants of the Request() functions for headers #574

Merged
merged 1 commit into from Jun 3, 2020
Merged

add Msg variants of the Request() functions for headers #574

merged 1 commit into from Jun 3, 2020

Conversation

ripienaar
Copy link
Contributor

Signed-off-by: R.I.Pienaar rip@devco.net

@ripienaar
Copy link
Contributor Author

In progress work to make Request() related functions support msg like PublishMsg(), probably dont need a ton of tests around this but will pick this up again tomorrow unless someone finish this before me

@coveralls
Copy link

coveralls commented Jun 2, 2020 •
edited

Coverage Status

Coverage decreased (-0.4%) to 91.021% when pulling c4ab892 on ripienaar:request_headers into e93e18d on nats-io:master.

ripienaar
ripienaar commented Jun 2, 2020
View reviewed changes
nats.go Show resolved Hide resolved
derekcollison
derekcollison reviewed Jun 2, 2020
View reviewed changes
context.go Outdated Show resolved Hide resolved
nats.go Outdated Show resolved Hide resolved
nats.go Outdated Show resolved Hide resolved
@ripienaar
add support for Requests using a Msg
c4ab892 
Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar
Copy link
Contributor Author

Redid this and also added a RespondMsg(), added tests

@ripienaar ripienaar marked this pull request as ready for review June 3, 2020 10:12
derekcollison
derekcollison approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit fdbf7d6 into nats-io:master Jun 3, 2020
@ripienaar ripienaar deleted the request_headers branch June 29, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ripienaar @coveralls @derekcollison