Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeleteMsg to JetStream management #631

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Add DeleteMsg to JetStream management #631

merged 1 commit into from
Jan 13, 2021

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jan 13, 2021

Adds DeleteMsg(name string, seq uint64) to JetStream management to be able to erase a message.

@wallyqs
Add DeleteMsg to JetStream management
9355a98 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 86.832% when pulling 9355a98 on wallyqs:jsm-delete-msg into be60b83 on nats-io:master.

derekcollison
derekcollison approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit acca6d6 into nats-io:master Jan 13, 2021
@wallyqs wallyqs deleted the jsm-delete-msg branch January 13, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallyqs @coveralls @derekcollison