js: Prevent sending duplicated Acks #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
force-pushed
the
js-ack-once
branch
3 times, most recently
from
1db4e05
to
bfd077e
Compare
derekcollison
requested changes
Jan 21, 2021
| func (m *Msg) Term() error { | ||
| return m.ackReply(AckTerm, false) | ||
| } | ||
|
|
||
| // Indicate that this message is being worked on and reset redelkivery timer in the server. | ||
| // InProgress indicates that this message is being worked on | ||
| // and reset the redelivery timer in the server. | ||
| func (m *Msg) InProgress() error { | ||
| return m.ackReply(AckProgress, false) |
There was a problem hiding this comment.
We could issue lots of these, the suppression code would suppress so we may need to look at ack type and the .ackd var.
There was a problem hiding this comment.
Updated to skip suppressing acks in case they are to progress report.
wallyqs
force-pushed
the
js-ack-once
branch
3 times, most recently
from
5dfda1a
to
b01f159
Compare
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suppression so that a msg is only attempted to be acked a single time (other than InProgress acks).
Fixes #634
Signed-off-by: Waldemar Quevedo wally@synadia.com