js: Remove JS timeout which got moved to JS context #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
| @@ -839,14 +834,6 @@ func Timeout(t time.Duration) Option { | |||
| } | |||
| } | |||
|
|
|||
| // JetStreamTimeout is an Option to set the timeout for access to the JetStream API | |||
| func JetStreamTimeout(t time.Duration) Option { | |||
There was a problem hiding this comment.
I use this one, what is it replaced with?
There was a problem hiding this comment.
Right now to be able to update the default JS API timeout, it has to be specified when creating the context, not when creating the connection for example:
nc.JetStream(nats.MaxWait(5*time.Second))There was a problem hiding this comment.
That is the way I use it.. So that is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Waldemar Quevedo wally@synadia.com