Make Durable mandatory for PullSubscribe #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Mar 29, 2021
| func (js *js) PullSubscribe(subj string, opts ...SubOpt) (*Subscription, error) { | ||
| return js.subscribe(subj, _EMPTY_, nil, nil, opts) | ||
| func (js *js) PullSubscribe(subj, durable string, opts ...SubOpt) (*Subscription, error) { | ||
| return js.subscribe(subj, _EMPTY_, nil, nil, append(opts, Durable(durable))) |
There was a problem hiding this comment.
should we prevent here that nats.Durable is passed so that it is not ambiguous?
There was a problem hiding this comment.
Ooh, yeah. Good idea.
There was a problem hiding this comment.
I updated nats.Durable to check if it has already been set. If so, it returns an error.
func Durable(name string) SubOpt {
return subOptFn(func(opts *subOpts) error {
if opts.cfg.Durable != "" {
return fmt.Errorf("nats: option Durable set more than once")
}
if strings.Contains(name, ".") {
return ErrInvalidDurableName
}
opts.cfg.Durable = name
return nil
})
}I also added this new test code.
sub, err = js.PullSubscribe("bar", "foo", nats.Durable("bar"))
if err == nil {
t.Fatalf("Unexpected success")
}
if err != nil && err.Error() != `nats: option Durable set more than once` {
t.Errorf("Expected consumer in pull mode error, got %v", err)
}
nats.Durable is a SubOpt that may be passed to PullSubscribe or other methods. If a durable name isn't passed to PullSubscribe, then we return a runtime error. Instead of returning a runtime error for this case, this change updates the PullSubscribe method to require a durable name parameter.
variadico
force-pushed
the
pull-durable-req
branch
from
c2a8114
to
077cf10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nats.Durable is a SubOpt that may be passed to PullSubscribe or other
methods. If a durable name isn't passed to PullSubscribe, then we return
a runtime error.
Instead of returning a runtime error for this case, this change updates
the PullSubscribe method to require a durable name parameter.