Update handling of account authentication expired error #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this merge, this test should be updated in the server: nats-io/nats-server@master...wallyqs:auth-acc-expired-err |
wallyqs
commented
Mar 30, 2021
nats_test.go
Outdated
| @@ -1651,6 +1651,107 @@ func TestRevokedUserCredentials(t *testing.T) { | |||
| wg.Wait() | |||
| } | |||
|
|
|||
| func TestExpiredAccountAuthentication(t *testing.T) { | |||
There was a problem hiding this comment.
Think some of these tests should be refactored into table driven tests since too similar, I'll update the PR
wallyqs
force-pushed
the
auth-acc-expired-err
branch
from
0dc0560
to
d0e4a07
Compare
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
wallyqs
force-pushed
the
auth-acc-expired-err
branch
from
d0e4a07
to
bd7b51f
Compare
|
@kozlovic there were three types of expired/revoked errors that had to be handled in the same way, I changed into table driven tests so that it is easier to add/remove these special cases /cc @matthiashanel {"expired users credentials", AUTHENTICATION_EXPIRED_ERR, ErrAuthExpired},
{"revoked users credentials", AUTHENTICATION_REVOKED_ERR, ErrAuthRevoked},
{"expired account", ACCOUNT_AUTHENTICATION_EXPIRED_ERR, ErrAccountAuthExpired}, |
kozlovic
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies similar handling
-ERR 'Account Authentication Expirederror as with others auth expired errors.Signed-off-by: Waldemar Quevedo wally@synadia.com