[ADDED] Support for Websocket protocol

[kozlovic]

Websocket protocol will be used as long as the URL scheme is ws or wss.
Note that no mixing of websocket and non-websocket URLs can be used (in the list of servers). Once a client connects, the gossip will be augmenting the URLs of that "type".

A Compression() option was added, which is currently documented as being used only for Websocket connections.

[derekcollison]

LGTM - Like the way you have organized things, will serve us well IMO.

Any data on performance changes?

[ripienaar]

Very exciting :)

[ripienaar]

LGTM, also curious about performance

[kozlovic]

Not sure if you are asking about performance of WS or impact of refactoring on non WS. For the later, quick dirty test.

From master:

$ go run examples/nats-bench/main.go -np 10 -ns 1 -n 10000000 foo
Starting benchmark [msgs=10000000, msgsize=128, pubs=10, subs=1]
NATS Pub/Sub stats: 5,511,378 msgs/sec ~ 672.78 MB/sec
 Pub stats: 2,755,819 msgs/sec ~ 336.40 MB/sec
..
 Sub stats: 2,755,838 msgs/sec ~ 336.41 MB/sec

From ws branch:

$ go run examples/nats-bench/main.go -np 10 -ns 1 -n 10000000 foo
Starting benchmark [msgs=10000000, msgsize=128, pubs=10, subs=1]
NATS Pub/Sub stats: 5,595,547 msgs/sec ~ 683.05 MB/sec
 Pub stats: 2,798,012 msgs/sec ~ 341.55 MB/sec
...
 Sub stats: 2,798,307 msgs/sec ~ 341.59 MB/sec

So really no impact on this test.
For Websocket perf:

$ go run examples/nats-bench/main.go -s ws://127.0.0.1:8080 -np 10 -ns 1 -n 10000000 foo
Starting benchmark [msgs=10000000, msgsize=128, pubs=10, subs=1]
NATS Pub/Sub stats: 4,921,103 msgs/sec ~ 600.72 MB/sec
 Pub stats: 2,460,663 msgs/sec ~ 300.37 MB/sec
...
 Sub stats: 2,460,640 msgs/sec ~ 300.37 MB/sec

[ripienaar]

Amazing.

[coveralls]

Coverage increased (+0.8%) to 86.957% when pulling 995f671 on ws into 6cee9f0 on master.

[derekcollison]

That's awesome.

[ColinSullivan1]

LGTM. Nice!

[mirusky]

Hi guys, thanks for your work.

Just some questions

• When this will be available?
• Or it's safe to use branch ws while this isn't merged?

[kozlovic]

@mirusky Thanks! We actually going to likely merge this in the main branch once the review is complete and Websocket will be part of the upcoming v1.11.0 release.

[kozlovic]

@ColinSullivan1 Please have a look at c8c0b60 and see if it helps.

[ColinSullivan1]

LGTM - thanks Ivan!