Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Websocket: use 80/443 as default ports #879

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Jan 8, 2022

If no port is specified in the URL, port 80 will be used if scheme
is "ws://" and port 443 will be used if scheme is "wss://".

Resolves #876

Signed-off-by: Ivan Kozlovic ivan@synadia.com

If no port is specified in the URL, port 80 will be used if scheme
is "ws://" and port 443 will be used if scheme is "wss://".

Resolves #876

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 85.041% when pulling 1752fac on fix_876 into 8f26cec on main.

@kozlovic kozlovic merged commit a915f85 into main Jan 8, 2022
@kozlovic kozlovic deleted the fix_876 branch January 8, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assume port 80/443 for ws:// and wss:// connection URIs if not specified instead of 4222.
3 participants