Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending ack when AckNonePolicy is set #987

Merged
merged 1 commit into from Jun 2, 2022
Merged

Fix sending ack when AckNonePolicy is set #987

merged 1 commit into from Jun 2, 2022

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Jun 2, 2022

This fixes #986

@piotrpio piotrpio requested review from wallyqs and aricart June 2, 2022 13:33
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.873% when pulling ffc3c71 on ack-none-policy into b795e86 on main.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit ce0cf21 into main Jun 2, 2022
@wallyqs wallyqs deleted the ack-none-policy branch June 2, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe sends ack even if AckPolicy is set to "none"
5 participants