KV and OS Compression and Metadata #1034
Conversation
scottf
commented
Oct 30, 2023
•
scottf
commented
- Add compression and metadata support to KV and OS
- Some test efficiency improvements.
- JsonValue utility improvements to support toString for KV and OS objects
- Removal of EXPERIMENTAL label on Object Store
Also less generic test names for efficiency
| */ | ||
| public long getMaxBucketSize() { | ||
| return sc.getMaxBytes(); | ||
| } |
There was a problem hiding this comment.
Moved here because it's common to KV and OS
| return sc.getCompressionOption() == JS_COMPRESSION_YES; | ||
| } | ||
|
|
||
| protected static abstract class Builder<B, FC> { |
There was a problem hiding this comment.
Moved here b/c common to KV and OS. Should have been this way originally.
| */ | ||
| public long getMaxBucketSize() { | ||
| return sc.getMaxBytes(); | ||
| } |
| */ | ||
| public Republish getRepublish() { | ||
| return sc.getRepublish(); | ||
| } |
| @@ -346,7 +346,7 @@ public KeyValueConfiguration build() { | |||
| .build()); | |||
| } | |||
| } | |||
| else if (sources.size() > 0) { | |||
| else if (!sources.isEmpty()) { | |||
There was a problem hiding this comment.
Intellij hounds me about these. isEmpty checks the internal size variable. not sure why it always wants this, but it's the same amount of function calls
| public long getMaxBucketSize() { | ||
| return sc.getMaxBytes(); | ||
| } | ||
|
|
There was a problem hiding this comment.
common to KV and OS
| @@ -668,7 +668,6 @@ enum Status { | |||
|
|
|||
| /** | |||
| * Gets a context for working with an Object Store. | |||
| * OBJECT STORE IMPLEMENTATION IS EXPERIMENTAL AND SUBJECT TO CHANGE. | |||
There was a problem hiding this comment.
Passing compatibility tests, can remove the EXPERIMENTAL label.
| mb.put("metaData", getMetadata()); | ||
| return mb.toJsonValue(); | ||
| } | ||
|
|
There was a problem hiding this comment.
All this just to have easy toString()
| */ | ||
| public Mirror getMirror() { | ||
| return sc.getMirror(); | ||
| } |
| */ | ||
| public List<Source> getSources() { | ||
| return sc.getSources(); | ||
| } |
| @@ -157,8 +170,7 @@ public Builder(KeyValueConfiguration kvc) { | |||
| * @return the builder | |||
| */ | |||
| public Builder name(String name) { | |||
| this.name = validateBucketName(name, true); | |||
| return this; | |||
| return super.name(name); | |||
There was a problem hiding this comment.
I did not have to override these, but it allows me to have more specific api comments.
| @@ -442,7 +442,7 @@ public boolean isDiscardNewPerSubject() { | |||
| } | |||
|
|
|||
| /** | |||
| * Metadata for the consumer | |||
| * Metadata for the stream | |||
There was a problem hiding this comment.
Bad old copy paste fixed.
| @@ -49,6 +49,8 @@ public enum Type { | |||
| public final Object object; | |||
| public final Number number; | |||
|
|
|||
| public final List<String> mapOrder; | |||
There was a problem hiding this comment.
helps toString to run through the map keys in a specific order, instead of whatever the keySet iterator would give.
| @@ -347,6 +347,10 @@ public static String variant(Object variant) { | |||
| return variant == null ? NUID.nextGlobalSequence() : "" + variant; | |||
| } | |||
|
|
|||
| public static String variant() { | |||
| return NUID.nextGlobalSequence(); | |||
| } | |||
There was a problem hiding this comment.
changes in this class are part of making the tests more efficient
