Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSLContextFactory #1101

Merged
merged 3 commits into from
Mar 24, 2024
Merged

SSLContextFactory #1101

merged 3 commits into from
Mar 24, 2024

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Mar 22, 2024

Adding an SSLContextFactory allows Options to take a class name property for the factory to which makes an SSLContext, instead of having to provide a concrete implementation. This allows classes using the library more flexibility.

@scottf scottf requested a review from jnmoyne March 22, 2024 21:26
Copy link

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 7cd5785 into main Mar 24, 2024
2 checks passed
@scottf scottf deleted the ssl-context-factory branch March 24, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants