gradle minor improvements, support windows #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Dec 4, 2020
| def tag = System.getenv("TRAVIS_TAG") != null ? System.getenv("TRAVIS_TAG") : ""; | ||
| def useSigning = "true".equals(secureEnv) && ("master".equals(branch) || (!"".equals(tag) && tag.equals(branch))) // tag will be the branch on a tag event for travis | ||
| def secureEnv = System.getenv("TRAVIS_SECURE_ENV_VARS") != null ? System.getenv("TRAVIS_SECURE_ENV_VARS") : "false" | ||
| def branch = System.getenv("TRAVIS_BRANCH") != null ? System.getenv("TRAVIS_BRANCH") : "" |
There was a problem hiding this comment.
groovy does not require semi-colons
scottf
commented
Dec 4, 2020
| def secureEnv = System.getenv("TRAVIS_SECURE_ENV_VARS") != null ? System.getenv("TRAVIS_SECURE_ENV_VARS") : "false" | ||
| def branch = System.getenv("TRAVIS_BRANCH") != null ? System.getenv("TRAVIS_BRANCH") : "" | ||
| def tag = System.getenv("TRAVIS_TAG") != null ? System.getenv("TRAVIS_TAG") : "" | ||
| def useSigning = "true" == secureEnv && ("master" == branch || ("" != tag && tag == branch)) // tag will be the branch on a tag event for travis |
There was a problem hiding this comment.
groovy treats == like java equals(), not like in java as object equivalency
scottf
commented
Dec 4, 2020
| @@ -134,6 +135,7 @@ javadoc { | |||
| excludes = ['io/nats/client/impl', 'io/nats/examples'] | |||
| classpath = sourceSets.main.runtimeClasspath | |||
| doLast { | |||
| if (!OperatingSystem.current().isWindows()) { | |||
There was a problem hiding this comment.
this allows the build to work on windows while not affecting any other operating system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.