Add a flushBuffer API #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Sullivan <colin@synadia.com>
| try { | ||
| dataPort.flush(); | ||
| } catch (Exception e) { | ||
| // NOOP |
There was a problem hiding this comment.
pass it along? technically you don't know if it got flushed
| @@ -29,6 +29,9 @@ | |||
|
|
|||
| import io.nats.client.Options; | |||
|
|
|||
| /** | |||
| * This class is not theadsafe. Caller must ensure thread safety. | |||
| */ | |||
| public class SocketDataPort implements DataPort { | |||
There was a problem hiding this comment.
I'm not sure why it was public, perhaps for testing. Good point though. I might take a pass through the classes outside of this PR.
| /** | ||
| * Immediately flushes the underlying connection buffer if the connection is valid. | ||
| */ | ||
| public void flushBuffer(); |
There was a problem hiding this comment.
I was on the fence, but yeah - probably good to let the user handle that.
sasbury
approved these changes
Dec 16, 2020
Signed-off-by: Colin Sullivan <colin@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flush buffer API to flush the underlying socket (through the socket output stream).
I did use a synchronized API on the connection writer because research seemed to indicate the best performance with a smaller number of threads - at least in older versions of java. It also fit well with the current architecture since there is no connection level locking. Instead publish synchronization resolves around the message writer and message queue. There's a small chance when publishing and immediately doing a flushBuffer, the flushBuffer will beat the message writer, but without major surgery I'm not sure how to fix that.
Regardless, I was able to exceed capacity of the underlying message queue unless I flushed in the test itself so performance doesn't seem to be impacted much.
CC /@scottf @RichardHightower
Signed-off-by: Colin Sullivan colin@synadia.com