Manage api constants immutable #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scottf
commented
Feb 11, 2021
•
scottf
commented
- management api read with examples
- ApiConstants to share filed name constants and Json patterns
- api objects made immutable
- reusable JsonUtils methods to read fields to simplify construction and support immutability
- ConsumerConfiguration maxWaiting not a field.
- Verified default field values according to jetstream/api/v1 some -1 changes to 0, max_waiting removed, addresses TODOs
| private final boolean success; | ||
| private final int purged; | ||
|
|
||
| public PurgeResponse(String json) { |
There was a problem hiding this comment.
Does this need to be public?
| return success; | ||
| } | ||
|
|
||
| public int getPurged() { |
| @@ -0,0 +1,103 @@ | |||
| package io.nats.client; | |||
| private final ZonedDateTime firstTime; | ||
| private final ZonedDateTime lastTime; | ||
|
|
||
| public StreamState(String json) { |
There was a problem hiding this comment.
Does this need to be public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.