-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription filter subject #560
Conversation
* server such as timeout or interruption | ||
* @throws JetStreamApiException the request had an error related to the data | ||
*/ | ||
JetStreamSubscription bindSubscribePushSync(String stream, String durable) throws IOException, JetStreamApiException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have parity with go?
@@ -330,6 +302,34 @@ public boolean getHeadersOnly() { | |||
return headersOnly != null && headersOnly; | |||
} | |||
|
|||
public boolean wouldBeChangeTo(ConsumerConfiguration original) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be made internal?
@@ -745,7 +745,7 @@ public String toString() { | |||
this.server = server; | |||
} | |||
|
|||
long initial() { | |||
public long initial() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the new APIs are made internal, or if intended to be public they need to be Camel Cased and documented.
No description provided.