Ordered consumer #563
Closed
Ordered consumer #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o subscription-filter-subject
# Conflicts: # src/main/java/io/nats/client/impl/NatsJetStream.java
| * Gets whether deliver policy of this consumer configuration was set or left unset | ||
| * @return true if the policy was set, false if the policy was not set | ||
| */ | ||
| public boolean deliverPolicyWasSet() { |
There was a problem hiding this comment.
Not objecting per se, but do all of these need to be public? Anything public must be supported until at least the next major version.
There was a problem hiding this comment.
It's a packaging problem. Not sure how to get around it all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.