Value or default bug #635
Merged
Value or default bug #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Apr 22, 2022
| @@ -175,7 +175,7 @@ public String toJson() { | |||
| JsonUtils.addField(sb, DELIVER_SUBJECT, deliverSubject); | |||
| JsonUtils.addField(sb, DELIVER_GROUP, deliverGroup); | |||
| JsonUtils.addField(sb, DELIVER_POLICY, GetOrDefault(deliverPolicy).toString()); | |||
| JsonUtils.addField(sb, OPT_START_SEQ, startSeq); | |||
| JsonUtils.addUnsigned(sb, OPT_START_SEQ, startSeq); | |||
There was a problem hiding this comment.
add as unsigned writes if the value is greater than 0 versus addField writes it if it's greater or equal to 0
There was a problem hiding this comment.
Naming of addUnsigned method seems confusing. Is not 0 (zero) an unsigned integer? Why would I expect a side-effect that 0 (zero) is ignored?
| @@ -998,7 +998,7 @@ public enum CcChangeHelper { | |||
| } | |||
|
|
|||
| public long valueOrDefault(Long val) { | |||
| return val == null ? START_SEQ.Default : val; | |||
| return val == null ? Default : val; | |||
There was a problem hiding this comment.
the other code was just wrong. This was introduced in a previous 2.14.1 PR so has not been released yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing server defaults and unsigned ints better