object store implementation. #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some shared code. Also fixes some documentation and removes beta tag from KV
scottf
changed the title
…ect-store-partial-1
scottf
requested review from
RichardHightower,
tbeets and
piotrpio
and removed request for
arondi
RichardHightower
approved these changes
Aug 30, 2022
| /** | ||
| * Get the name of the object store's bucket. | ||
| * THIS IS A BETA FEATURE AND SUBJECT TO CHANGE | ||
| * @return the name |
There was a problem hiding this comment.
please add API comments
| ObjectInfo put(ObjectMeta meta, InputStream inputStream) throws IOException, JetStreamApiException, NoSuchAlgorithmException; | ||
| ObjectInfo put(String name, InputStream inputStream) throws IOException, JetStreamApiException, NoSuchAlgorithmException; | ||
| ObjectInfo put(String name, byte[] input) throws IOException, JetStreamApiException, NoSuchAlgorithmException; | ||
| ObjectInfo put(File file) throws IOException, JetStreamApiException, NoSuchAlgorithmException; |
| * The FeatureOptions class specifies the general options for features. | ||
| * Options are created using the {@link FeatureOptions.Builder Builder}. | ||
| */ | ||
| public class FeatureOptions { |
There was a problem hiding this comment.
Should this be abstract?
RichardHightower
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object Store Implementation and Test
Additional unit test coverage.
Also fixes some documentation and removes beta tag from KV