Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] [SRV] service response types #818

Merged
merged 4 commits into from
Dec 28, 2022
Merged

[FEAT] [SRV] service response types #818

merged 4 commits into from
Dec 28, 2022

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Dec 28, 2022

No description provided.

arondi
arondi requested changes Dec 28, 2022
View reviewed changes
src/main/java/io/nats/service/Service.java Outdated
@@ -171,8 +171,8 @@ public Info getInfo() {
return info;
}

public SchemaInfo getSchemaInfo() {
return schemaInfo;
public SchemaResponse getSchemaInfo() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSchemaResponse

arondi
arondi approved these changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@arondi arondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit b85cdfa into main Dec 28, 2022
@scottf scottf deleted the service-type branch December 28, 2022 21:16
@scottf scottf changed the title service type field service response type Dec 30, 2022
@scottf scottf changed the title service response type service response types Dec 30, 2022
@scottf scottf changed the title service response types [FEAT] [SRV] service response types Dec 30, 2022
@scottf scottf mentioned this pull request Dec 30, 2022
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arondi arondi arondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottf @arondi