Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

message size calculation improvements #820

Merged
merged 8 commits into from
Jan 9, 2023
Merged

message size calculation improvements #820

merged 8 commits into from
Jan 9, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Dec 30, 2022

No description provided.

MauriceVanVeen
MauriceVanVeen approved these changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small questions, looking good 👍

build.gradle Outdated Show resolved Hide resolved
src/test/java/io/nats/client/NatsTestServer.java Show resolved Hide resolved
@scottf scottf merged commit c610d57 into main Jan 9, 2023
@scottf scottf deleted the message-size-calculation-improvements branch January 9, 2023 15:17
@scottf scottf mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottf @MauriceVanVeen