Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] consistent validation and version comparison fix #823

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Jan 3, 2023

Consistent validation across Stream, KeyValue and ObjectStore configuration #821
Version comparison fix #822

@scottf scottf changed the title [FIX] consistent validation [FIX] consistent validation and version comparison fix Jan 3, 2023
Copy link
Collaborator

@arondi arondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks


/**
* Default Builder
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix comments


/**
* Creates a builder for the Object Store Configuration.
* @param name the name of the object store bucket
* @return an Object Store configuration builder
* @return an Object Store configuration Builder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObjectStoreConfiguration Builder

this((ObjectStoreConfiguration)null);
}

public Builder(String name) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

@scottf scottf merged commit 8e35e0f into main Jan 3, 2023
@scottf scottf deleted the consistent-validation branch January 3, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServerInfo.getComparableVersion not compatible with NATS Version 2.9.10
2 participants