-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] consistent validation and version comparison fix #823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicks
|
||
/** | ||
* Default Builder | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix comments
|
||
/** | ||
* Creates a builder for the Object Store Configuration. | ||
* @param name the name of the object store bucket | ||
* @return an Object Store configuration builder | ||
* @return an Object Store configuration Builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ObjectStoreConfiguration Builder
this((ObjectStoreConfiguration)null); | ||
} | ||
|
||
public Builder(String name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment
Consistent validation across Stream, KeyValue and ObjectStore configuration #821
Version comparison fix #822