Add Options.builder() method to get the builder in a more "fluent" manner #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
scottf
requested changes
Jan 23, 2023
| * Creates a builder for the options. | ||
| * @return the builder. | ||
| */ | ||
| public static Builder newBuilder() { |
There was a problem hiding this comment.
- To be consistent with all the other builders, please name this method just
builder. - Can you move it below the comments for the builder, just before the class declaration.
- While you are there, can you remove the comment (line 582 in this code)
is equivalent to calling {@link Nats#connect() Nats.connect()}.It isn't right. - Last, can you please sign your commits. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
scottf
changed the title
Options#builder() (#831)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No much to explain to be honest.