use standard connection create inbox for discovery #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user to provide their own supplier.
unixunion
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
I have successfully tested this by building a snapshot of jnats and retrofitting a demo app to use the new inboxSupplier. So the PING inbox topic can now be correctly set when using JWT's for restricting access.
Discovery discovery = new Discovery(nc, 1000, 3);
discovery.setInboxSupplier(new CustomInboxSupplier());
List<PingResponse> pingResponses = discovery.ping();
2023-03-14T07:57:44.355+01:00 INFO 65558 --- [ main] c.k.a.n.demos.schemas.MicroClientHelper : Discovered: "PingResponse":{"id":"Hxx8Kh9k5MhGtJp9OlFnoF","name":"HelloWorld-Service","version":"0.0.1-SNAPSHOT","type":"io.nats.micro.v1.ping_response"}
2023-03-14T07:57:44.355+01:00 INFO 65558 --- [ main] c.k.a.n.demos.schemas.MicroClientHelper : Info...
2023-03-14T07:57:45.359+01:00 INFO 65558 --- [ main] c.k.a.n.demos.schemas.MicroClientHelper : Info: "InfoResponse":{"id":"Hxx8Kh9k5MhGtJp9OlFnoF","name":"HelloWorld-Service","version":"0.0.1-SNAPSHOT","description":"A rich greeter experience","subjects":["hello"],"type":"io.nats.micro.v1.info_response"}
2023-03-14T07:57:45.359+01:00 INFO 65558 --- [ main] c.k.a.n.demos.schemas.MicroClientHelper : Schemas...
2023-03-14T07:57:46.366+01:00 INFO 65558 --- [ main] c.k.a.n.demos.schemas.MicroClientHelper : Schema: "SchemaResponse":{"id":"Hxx8Kh9k5MhGtJp9OlFnoF","name":"HelloWorld-Service","version":"0.0.1-SNAPSHOT","api_url":"http:\/\/spec.url","endpoints":[{"name":"HelloWorld","subject":"hello","schema":{"request":"syntax = \"proto3\";\npackage com.kindredgroup.arch.nats.demos;\n\nimport \"Common.proto\";\n\noption java_package = \"com.kindredgroup.arch.nats.demos.schemas\";\noption java_outer_classname = \"HelloWorldRequestProto\";\n\nmessage HelloWorldRequest {\n Header header = 1;\n string name = 2;\n}","response":"syntax = \"proto3\";\npackage com.kindredgroup.arch.nats.demos;\n\nimport \"Common.proto\";\n\noption java_package = \"com.kindredgroup.arch.nats.demos.schemas\";\noption java_outer_classname = \"HelloWorldResponseProto\";\n\nmessage HelloWorldResponse {\n Header header = 1;\n string greeting = 2;\n}"}}],"type":"io.nats.micro.v1.schema_response"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also allow the user to provide their own supplier. Addressing #856