Pull-fetch-time-left #879
Merged
Pull-fetch-time-left #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
requested changes
Apr 5, 2023
src/main/java/io/nats/client/impl/NatsJetStreamPullSubscription.java
Outdated
Show resolved
Hide resolved
pramodin
reviewed
Apr 6, 2023
| while (batchLeft > 0 && timeLeft > 0) { | ||
| Message msg = nextMessageInternal( Duration.ofMillis(timeLeft) ); | ||
| long maxWaitNanos = maxWaitMillis * 1_000_000; | ||
| long timeLeftNanos = maxWaitNanos; |
There was a problem hiding this comment.
Shouldn't timeLeftNanos be initialized to maxWaitNanos - (System.nanoTime() - start) as well?
There was a problem hiding this comment.
I think the reasoning here is that we want to at least allow processing a single message to send back, which could no longer be the case if timeLeftNanos is set to maxWaitNanos - (System.nanoTime() - start) since we could set maxWaitNanos really small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use System.nanoTime() instead of System.currentTimeMillis() to move away from wall clock.