Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better testing checks against server versions #932

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Better testing checks against server versions #932

merged 1 commit into from
Jun 22, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Jun 22, 2023 •
edited

  • Improved version check utils for use in regression testing to ensure features are tested properly against server versions.
  • Fixed test running against 2.10 dev

@piotrpio piotrpio self-requested a review June 22, 2023 14:37
piotrpio
piotrpio approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 51fc9d6 into main Jun 22, 2023
2 checks passed
@scottf scottf deleted the better-test-version-check branch June 22, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottf @piotrpio