Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-nats can leave request timeouts active after closing #256

Closed
aricart opened this issue Mar 26, 2019 · 1 comment
Closed

node-nats can leave request timeouts active after closing #256

aricart opened this issue Mar 26, 2019 · 1 comment
Assignees

Comments

@aricart
Copy link
Member

aricart commented Mar 26, 2019

node-nats is not cleaning up request timeouts.
On close, all request timeouts should be canceled:

Client.prototype.clearMuxTimeouts = function() {
    if(this.respmux) {
        for (var p in this.respmux.requestMap) {
            if (this.respmux.requestMap.hasOwnProperty(p)) {
                this.cancelMuxRequest(p)
            }
        }
    }
}
@aricart aricart self-assigned this Mar 26, 2019
@aricart
Copy link
Member Author

aricart commented Mar 26, 2019

Or for that matter subscriptions that specify a timeout.

aricart added a commit that referenced this issue Mar 27, 2019
FIX #256 - Fix requets and subscription timers left active after a close.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant