Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disconnect should only be notified if the current connection fails #257

Closed
aricart opened this issue Mar 27, 2019 · 0 comments
Closed

disconnect should only be notified if the current connection fails #257

aricart opened this issue Mar 27, 2019 · 0 comments

Comments

@aricart
Copy link
Member

aricart commented Mar 27, 2019

Currently, as the node-nats tries to establish a connection, the stream handler notifies of a disconnect even when the client was not able to connect.
aricart added a commit that referenced this issue Mar 27, 2019
@aricart
FIX #257 - Fixed multiple disconnect notifications from node-nats, th…
7bd8fd0 
…ese affect downstream clients (such as node-nats-streaming), as the disconnects are raised when the client attempts to connect but fails.
@aricart aricart mentioned this issue Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aricart