Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [NBC] dns-resolve #458

Merged
merged 3 commits into from Oct 7, 2021
Merged

[FEAT] [NBC] dns-resolve #458

merged 3 commits into from Oct 7, 2021

Conversation

aricart
Copy link
Member

@aricart aricart commented Oct 5, 2021

The node client will now try to resolve hostnames itself and attempt to connect to any of the possible alternatives before trying a different named server. Resolved ips are shuffled by default unless noRandomize was set in the connection options

…gic slightly. If resolve is set to `true`, the client will resolve the DNS for the server and attempt to connect to any of the possible alternatives before cycling to the next server. This means that all alternatives are tried stopping only at the fist succeed. Unless the `noRandomize` option is specified, the resolved hosts will be shuffled.
@aricart aricart requested a review from kozlovic October 5, 2021 18:07
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why opt-in vs default behavior?

@aricart
Copy link
Member Author

aricart commented Oct 5, 2021

Why opt-in vs default behavior?

If we are doing semver, and make default is a change which to disable would require code - so this is a major version change. I am OK flip it.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[UPDATE] dev dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants