Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference new moduled jetstream #572

Merged
merged 2 commits into from
May 30, 2023
Merged

reference new moduled jetstream #572

merged 2 commits into from
May 30, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented May 26, 2023

No description provided.

@aricart aricart requested a review from Jarema May 26, 2023 14:30
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart changed the base branch from main to dev May 30, 2023 13:33
@aricart aricart merged commit 404ff95 into dev May 30, 2023
11 checks passed
@aricart aricart deleted the js-module branch May 30, 2023 13:33
aricart added a commit that referenced this pull request Jun 17, 2023
- [TEST] removed an auth test that is not applicable anymore
- [TEST] fixed JSM test that is flapping with current server
- [DEP] removed tslint build dependency
- [TEST] added consumers canary test
- [CHANGE] reference new moduled jetstream (#572)
- [FIX] changes to match internals from js-module
- [CHANGE] updated lib mod.ts to re-export jetstream/mod (as jetstream was moved to jetstream/ dir), and also fix directly importing deps from specific files that were relocated.
- [TEST] removed the test that required only Uint8Array (now strings are also possible)
- [BUMP] to reference nbc v1.15.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants