Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] added noop implementation for discard() api #580

Merged
merged 1 commit into from Aug 1, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Aug 1, 2023

Transport interface added a discard() method, to allow for websocket discards on transports that throttle, this is a noop on nodejs tcp

@aricart aricart requested a review from Jarema August 1, 2023 20:30
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 9a1016a into main Aug 1, 2023
11 checks passed
@aricart aricart deleted the transport-discard-api branch August 1, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants