Prevent KeyValueStore error when MaxAge is set below the default Dupl…

…icateWindow value (#362)
nats-io · Mar 11, 2024 · 5cbe4e2 · 5cbe4e2
1 parent 56f831f
commit 5cbe4e2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/NATS.Client.KeyValueStore/NatsKVContext.cs b/src/NATS.Client.KeyValueStore/NatsKVContext.cs
@@ -108,9 +108,13 @@ public async ValueTask<INatsKVStore> CreateStoreAsync(NatsKVConfig config, Cance
             // MirrorDirect =
             // Mirror =
             Retention = StreamConfigRetention.Limits, // from ADR-8
-            DuplicateWindow = TimeSpan.FromMinutes(2), // 120_000_000_000ns, from ADR-8
+            DuplicateWindow = config.MaxAge != default ? config.MaxAge : TimeSpan.FromMinutes(2), // 120_000_000_000ns, from ADR-8
         };
 
+        // https://github.com/nats-io/nats.go/blob/98430acd80423b776149f29d625d158f490ac3c5/jetstream/kv.go#L334-L342
+        if (streamConfig.MaxAge > TimeSpan.Zero && streamConfig.MaxAge < streamConfig.DuplicateWindow)
+            streamConfig.DuplicateWindow = streamConfig.MaxAge;
+
         var stream = await _context.CreateStreamAsync(streamConfig, cancellationToken);
 
         return new NatsKVStore(config.Bucket, _context, stream);