Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle publish serialization exceptions #144

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Handle publish serialization exceptions #144

merged 1 commit into from
Oct 5, 2023

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Oct 5, 2023

No description provided.

@mtmk mtmk linked an issue Oct 5, 2023 that may be closed by this pull request
Serialization exception swallowed when NatsPubOpts.WaitUntilSent = false #138
Closed
@mtmk mtmk requested a review from caleblloyd October 5, 2023 10:41
@mtmk mtmk mentioned this pull request Oct 5, 2023
Closed
caleblloyd
caleblloyd approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 6a9515d into main Oct 5, 2023
9 checks passed
@mtmk mtmk deleted the 138-pub-serialization-exception-swallowed branch October 5, 2023 14:58
@mtmk mtmk mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization exception swallowed when NatsPubOpts.WaitUntilSent = false
2 participants
@mtmk @caleblloyd