Key/Value and Object Store compression

[mtmk]

contributes to nats-io/nats-architecture-and-design#253

[caleblloyd]

Looks like Deno uses Compression with the actual Compression options in the config. Which makes more sense if there will ultimately be multiple Compression options to choose from

[caleblloyd]

https://github.com/nats-io/nats.deno/pull/625/files

[mtmk]

Looks like Deno uses Compression with the actual Compression options in the config. Which makes more sense if there will ultimately be multiple Compression options to choose from

I think there was a discussion about it and ADR says it should be bool also Go and Java using bool. Not sure why deno is different also rust looks the same as well. huh?!

[mtmk]

Turns out it should be bool.

[caleblloyd]

Naming wise - I would expect the Config param to be something like bool EnableCompression. This conveys that I am turning on a feature called "compression". Versus IsCompressed conveys that some data I will put in this stream is already compressed

But for the Status param IsCompressed is fine

What do the other Clients call the Config param? Or is there a matching Stream Config param name that we should align?

[mtmk]

What do the other Clients call the Config param? Or is there a matching Stream Config param name that we should align?

Go is using 'Compression' and 'IsCompressed'. ADR is the same.

[caleblloyd]

LGTM