Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer notifications #265

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Consumer notifications #265

merged 4 commits into from
Nov 30, 2023

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Nov 30, 2023

Consume and fetch methods now generates notifications for unhandled
errors. Also the unrecoverable 409 errors will stop the consume loop
with an exception in addition to 400 and 404 errors.

resolves #236
resolves #264

Consume and fetch methods now generates notifications for unhandled
errors. Also the unrecoverable 409 errors will stop the consume loop
with an exception in addition to 400 and 404 errors.
# Conflicts:
#	src/NATS.Client.JetStream/INatsJSNotification.cs
@mtmk mtmk requested a review from caleblloyd November 30, 2023 15:50
Copy link
Contributor

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 87b897b into main Nov 30, 2023
4 of 9 checks passed
@mtmk mtmk deleted the consumer-notifications branch November 30, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants