Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV get keys should not hang with deleted keys #293

Merged
merged 1 commit into from
Dec 22, 2023
Merged

KV get keys should not hang with deleted keys #293

merged 1 commit into from
Dec 22, 2023

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Dec 21, 2023

No description provided.

@mtmk mtmk requested a review from caleblloyd December 21, 2023 12:46
@mtmk mtmk linked an issue Dec 21, 2023 that may be closed by this pull request
When the last KV store operation is a Delete, the GetKeysAsync will not break from loop and keep waiting #292
Closed
caleblloyd
caleblloyd approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 0cf8666 into main Dec 22, 2023
9 checks passed
@mtmk mtmk deleted the 292-kv-loop-hangs branch December 22, 2023 09:47
@mtmk mtmk mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the last KV store operation is a Delete, the GetKeysAsync will not break from loop and keep waiting
2 participants
@mtmk @caleblloyd