Fixed serialization problem in PublishModel/PublishHeaders examples #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l/Header examples. - Added the reflection based JsonSerializer as default serializer. This way the Bar object can be (de)serialized and the examples work.
… default constructor.
mtmk
approved these changes
Dec 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the example projects
Example.Core.PublishModel,Example.Core.SubscribeModel,Example.Core.PublishHeadersandExample.Core.SubscribeHeadersare not working because the default serializer can not handle the customBartype. To make the programs work, we need to provide a serializer for that type.To achieve this, i added a project reference to
Nats.Client.Serializers.Jsonand configured theNatsJsonSerializerRegistryas SerializerRegistry in the mentioned projects.The same could be achieved by using the AOT ready
NatsJsonContextSerializerbut with we would need to create a customJsonSerializerContextfor theBartype in every project. To keep the required code as small as possible, i chose the reflection based serializer.