[OLD] Add OpenTelemetry Instrumentation #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add activity tracing * Added OpenTelemetry package # Conflicts: # NATS.Client.sln * Add OpenTelemetry extension * Remove aspire defaults project * Remove Aspire project * Build fixes --------- Co-authored-by: Ziya Suzen <ziya@suzen.net>
mtmk
changed the title
|
@mtmk I think we should hold off on this. I actually rewrote most of this to a different approach which:
I think it's a better approach, and so should be considered before merging the code in this branch here. I can probably find time to get it to a mergable state by the end of the week. Branch is here (I have some local changes not pushed as well) cc'ing Add OpenTelemetry Instrumentation #124 for visibility |
|
@Cooksauce, that sounds good to me. feel free to create a fresh PR. |
mtmk
changed the title
|
see #437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR here as a reference for a bit.