Ordered Consumer Heartbeat Handling #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Nov 15, 2022
| js.PushSubscribeAsync(null, (o, a) => { }, false, psoBind).Unsubscribe(); | ||
| UnsubscribeEnsureNotBound(js.PushSubscribeSync(null, psoBind)); | ||
| UnsubscribeEnsureNotBound(js.PushSubscribeSync("", psoBind)); | ||
| UnsubscribeEnsureNotBound(js.PushSubscribeAsync(null, (o, a) => { }, false, psoBind)); |
There was a problem hiding this comment.
Helps test on slow machines.
scottf
commented
Nov 15, 2022
| @@ -305,7 +305,7 @@ public void TestSourceBasics() | |||
|
|
|||
| private void AssertMirror(IJetStreamManagement jsm, | |||
| string stream, string mirroring, ulong? msgCount, ulong? firstSeq) { | |||
| Thread.Sleep(1000); | |||
| Thread.Sleep(1500); | |||
There was a problem hiding this comment.
more time for slow machines
scottf
commented
Nov 15, 2022
|
|
||
| internal static PushMessageManagerFactory PushMessageManagerFactoryImpl = | ||
| (conn, so, cc, queueMode, syncMode) => new PushMessageManager(conn, so, cc, queueMode, syncMode); | ||
| internal static PushMessageManagerFactory PushMessageManagerFactoryImpl; |
There was a problem hiding this comment.
This allows a factory to be set for testing. The default one is used later if this one is not set. Change makes sense in the context of sub classing versus multiple managers
scottf
commented
Nov 15, 2022
| using System.Collections.Generic; | ||
| using System.Threading; | ||
| using NATS.Client.Internals; | ||
|
|
There was a problem hiding this comment.
Split this file with multiple related classes into separate files matching the class name.
scottf
requested review from
ColinSullivan1,
RichardHightower,
sixlettervariables and
tbeets
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#700