Fill in Publish / Request Header Gaps #839 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Jan 27, 2023
| /// <param name="msg">A <see cref="Msg"/> instance containing the subject, optional reply, and data to publish | ||
| /// to the NATS server.</param> | ||
| /// <seealso cref="IConnection.Publish(string, byte[])"/> | ||
| void Publish(Msg msg); |
There was a problem hiding this comment.
this is just moved lower down for organizational purposes
scottf
commented
Jan 28, 2023
| /// <param name="timeout">The number of milliseconds to wait.</param> | ||
| /// <returns>A <see cref="Msg"/> with the response from the NATS server.</returns> | ||
| /// <seealso cref="IConnection.Request(Msg)"/> | ||
| Msg Request(Msg message, int timeout); |
There was a problem hiding this comment.
this is just moved up for organizational purposes
|
Is there a request for this? It is convenient but the API footprint if getting large with all of the overloads. In the past I nudged users toward msg API if they needed to use headers. |
scottf
changed the title
ColinSullivan1
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #736