[BUG] Missed inheriting code caused failure #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refactoring pull sync subscription class to have shared base abstract code in common with the push subscription, the push sync subscription class was copied to the abstract class, but was not changed to inherit from it. This caused calls to
sub.GetConsumerInfoto fail, since it didn't properly have the consumer name.This affects all Push subscriptions if the dev calls
sub.GetConsumerInfo, thankfully that's fairly uncommon. But...KeyValue watches use push under the covers and immediately callsub.GetConsumerInfo, so immediately fail.Sigh. Sorry. It's fixed now. I'll release 1.0.7 as soon as possible.