Add "num_replicas" field for consumer #326
Conversation
|
Hello @wallyqs . Would really appreciate if you can review this. A bit of urgent for us as we are moving to production and would want to be able to create R1 consumers. |
|
Thanks, tests are passing for my locally but there is format issue that making the CI fail. I can take a look later also before merging and releasing later today. |
|
Sounds good. Appreciate your effort and time 👏 |
| nc = await nats.connect() | ||
|
|
||
| js = nc.jetstream() | ||
| await js.add_stream(name="TESTREPLICAS", subjects=["test.replicas"]) |
There was a problem hiding this comment.
Hi @wallyqs Is there a way to make this stream R3 in the test case here?
This would strengthen the test so the streams is R3 and consumer is R1 and we can be 100% sure the replication factor for consumer is not inherited from the stream.
There was a problem hiding this comment.
I'd like that too, would have to make the tests run in cluster mode and right now they only run in single node (no helper for that in the tests atm)
|
Included with format fixes as part of #327 |
This adds
num_replicasfield to allow configuring the number of replicas for a durable consumer.